github / janky

Continuous integration server built on top of Jenkins and Hubot

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing builds for the same commit

halorgium opened this issue · comments

When the same commit is pushed to a different branch and commit was previously green, a new build for the new branch is not created.

I would expect a build notice in campfire and a green build on the web showing that something happened.

Could the build be a duplicate of the existing build, just pointing to the other branch?

I am over these notices to be honest. I guess it's because most of our merges happen via merge button which triggers a new build. If not, the branch build notice usually is a few lines above in the transcript when the fast-forward or merge hook pops in Campfire.

I think I agree with Simon. If there are no changes in the code why should a new build be created? even if we move the commit between branches the code is the same.

i can's speak to github internal workflow, but i could imagine that it won't necessarily be the same everywhere. while it's true that the same commit would produce the same result even on a different branch, and therefore it's unneccessary to run a new jenkins build, it may be useful to copy the build result for the new branch and notify of it's status.

this doesn't seem like it would be a difficult change.

@dustyburwell understands what i was meaning.
i don't want a new build, but merely a new object connecting the branch and the commit.
for me, it is about visibility into the build history of the commits on a certain branch.
if a commit is built and then merged into master without changes and then the old branch is removed, i would like to have a build pointing to that commit on the master branch.

We're falling back to using the github status api for this.