Giters

github / choosealicense.com

A site to provide non-judgmental guidance on choosing a license for your open source project

Home Page:https://choosealicense.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

replace qtip2

mlinksva opened this issue · comments

commented

https://github.com/qTip2/qTip2 not maintained in a long time, and functionality probably no longer requires javascript. Might https://github.com/chinchang/hint.css be a replacement?

Thoughts or PRs welcome.

commented

Hi @mlinksva! I hope you are doing great. I did a spike on the issue and here are my findings:

  • We can replace qTips2 with hint.css
  • However, we cannot remove JS from the functionality entirely:
    • We need to conditionally show the error qTip on the sidebar input here:
      image
  • We might need to compromise the design of qTips as hint.css just render text in qTip, whereas we are rendering a heading (Error) and text (Invalid url) for the qTips.

Overall, we can do this. Should I move forward with the issue?

commented

Thanks @chahmedejaz for doing the research/spike (I now see pure CSS limitations)! The heading/message in two colors is used also or license condition tooltips eg on https://choosealicense.com/licenses/. I'd be OK with changing the design to only be one line/one color, perhaps with the current heading, colon, then the current message. So yes, please do move forward with the issue!

commented

Hey @mlinksva, the PR is ready for review. Would love to hear your thoughts on it. Thanks :)

commented

Fixed by #1141