About the value of ConsulEndPoint.HostName

[Robin]

the namespace Gigya.Microdot.ServiceDiscovery
class ConsulClient
line: 494
var endpoints = nodes.Select(ep => new ConsulEndPoint { HostName = ep.Node.Name, Port = ep.Service.Port, Version = GetEndpointVersion(ep) }).OrderBy(x => x.HostName).ThenBy(x => x.Port).ToArray();
why HostName = ep.Node.Name and not ep.Node.Address or ep.Service.Address?

[daniel-lamberger]

If I remember correctly it's because we wanted to use logical host names in the events that our service proxy publishes when a call is done to some service. These events end up in a logging/tracing system (Kibana in our case) and developers generally prefer host names over IPs. However we're considering using addresses instead (or in addition to), to support discovering (non-microdot) services that are bound to specific network interfaces.

…

On Mon, Aug 13, 2018 at 9:10 AM, Robin ***@***.***> wrote: the namespace Gigya.Microdot.ServiceDiscovery class ConsulClient line: 494 var endpoints = nodes.Select(ep => new ConsulEndPoint { HostName = ep.Node.Name, Port = ep.Service.Port, Version = GetEndpointVersion(ep) }).OrderBy(x => x.HostName).ThenBy(x => x.Port).ToArray(); why HostName = ep.Node.Name and not ep.Node.Address or ep.Service.Address? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#195>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMbZxNpzeC4TTWFBU_uBAiqlliEn-_gVks5uQRhygaJpZM4V570l> .