Giters

gigya / microdot

Microdot: An open source .NET microservices framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix compiler warnings

Allon-Guralnek opened this issue · comments

commented

Currently when compiling Microdot, the compiler give 26 warnings. These should be fixed or suppressed.

  • Warning CS1574 XML comment has cref attribute 'HttpServiceAttribute' that could not be resolved Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\HttpService\IServiceEndPointDefinition.cs 52 Active
  • Warning CS1574 XML comment has cref attribute 'GigyaServiceHost' that could not be resolved Gigya.Microdot.SharedLogic C:\Git\Microdot\Gigya.Microdot.SharedLogic\ServiceArguments.cs 185 Active
  • Warning CS1574 XML comment has cref attribute 'HttpServiceAttribute' that could not be resolved Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\HttpService\ServiceMethod.cs 39 Active
  • Warning CS0618 'Thread.Suspend()' is obsolete: 'Thread.Suspend has been deprecated. Please use other classes in System.Threading, such as Monitor, Mutex, Event, and Semaphore, to synchronize Threads or protect resources. http://go.microsoft.com/fwlink/?linkid=14202' Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\Service\GigyaServiceHost.cs 286 Active
  • Warning CS0618 'StackTrace.StackTrace(Thread, bool)' is obsolete: 'This constructor has been deprecated. Please use a constructor that does not require a Thread parameter. http://go.microsoft.com/fwlink/?linkid=14202' Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\Service\GigyaServiceHost.cs 288 Active
  • Warning CS0168 The variable 'ex' is declared but never used Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\Service\GigyaServiceHost.cs 291 Active
  • Warning CS0618 'Thread.Resume()' is obsolete: 'Thread.Resume has been deprecated. Please use other classes in System.Threading, such as Monitor, Mutex, Event, and Semaphore, to synchronize Threads or protect resources. http://go.microsoft.com/fwlink/?linkid=14202' Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\Service\GigyaServiceHost.cs 294 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\CalculatorService\CalculatorWorkerGrain.cs 76 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\CalculatorService\CalculatorWorkerGrain.cs 88 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\CalculatorService\CalculatorWorkerGrain.cs 95 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\CalculatorService\CalculatorWorkerGrain.cs 102 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\CalculatorService\CalculatorWorkerGrain.cs 104 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\CalculatorService\CalculatorWorkerGrain.cs 106 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\ProgrammableHealthGrain.cs 43 Active
  • Warning CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. Gigya.Microdot.Orleans.Hosting.FunctionalTests C:\Git\Microdot\tests\Gigya.Microdot.Orleans.Hosting.FunctionalTests\Microservice\ProgrammableHealthGrain.cs 50 Active
  • Warning CS0169 The field 'Data.s' is never used Gigya.Microdot.ServiceContract.UnitTests C:\Git\Microdot\tests\Gigya.Microdot.ServiceContract.UnitTests\ServiceSchemaTests.cs 34 Active
  • Warning CS0169 The field 'Data.n' is never used Gigya.Microdot.ServiceContract.UnitTests C:\Git\Microdot\tests\Gigya.Microdot.ServiceContract.UnitTests\ServiceSchemaTests.cs 35 Active
  • Warning CS0169 The field 'Nested.time' is never used Gigya.Microdot.ServiceContract.UnitTests C:\Git\Microdot\tests\Gigya.Microdot.ServiceContract.UnitTests\ServiceSchemaTests.cs 40 Active
  • Warning CA1063 Provide an overridable implementation of Dispose(bool) on 'CustomTimings' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. Gigya.Microdot.SharedLogic C:\Git\Microdot\Gigya.Microdot.SharedLogic\Measurement\CustomTimings.cs 28 Active
  • Warning CA1063 Modify 'CustomTimings.Dispose()' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns. Gigya.Microdot.SharedLogic C:\Git\Microdot\Gigya.Microdot.SharedLogic\Measurement\CustomTimings.cs 79 Active
  • Warning CA1063 Provide an overridable implementation of Dispose(bool) on 'ComponentHealthMonitor' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. Gigya.Microdot.SharedLogic C:\Git\Microdot\Gigya.Microdot.SharedLogic\Monitor\ComponentHealthMonitor.cs 29 Active
  • Warning CA1063 Modify 'ComponentHealthMonitor.Dispose()' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns. Gigya.Microdot.SharedLogic C:\Git\Microdot\Gigya.Microdot.SharedLogic\Monitor\ComponentHealthMonitor.cs 87 Active
  • Warning CA2214 'IdentityServiceInterfaceMapper.IdentityServiceInterfaceMapper(Type[])' contains a call chain that results in a call to a virtual method defined by the class. Review the following call stack for unintended consequences:
  • IdentityServiceInterfaceMapper..ctor(Type[])
  • ServiceInterfaceMapper.set_ServiceInterfaceTypes(IEnumerable):Void Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\HttpService\IdentityServiceInterfaceMapper.cs 36 Active
  • Warning CA2213 'GigyaServiceHost' contains field 'GigyaServiceHost.k__BackingField' that is of IDisposable type: 'ManualResetEvent'. Change the Dispose method on 'GigyaServiceHost' to call Dispose or Close on this field. Gigya.Microdot.Hosting C:\Git\Microdot\Gigya.Microdot.Hosting\Service\GigyaServiceHost.cs 253 Active
  • Warning CA2213 'ServiceProxyProvider' contains field 'ServiceProxyProvider._httpMessageHandler' that is of IDisposable type: 'HttpMessageHandler'. Change the Dispose method on 'ServiceProxyProvider' to call Dispose or Close on this field. Gigya.Microdot.ServiceProxy C:\Git\Microdot\Gigya.Microdot.ServiceProxy\ServiceProxyProvider.cs 526 Active
  • Warning CA1001 Implement IDisposable on 'HttpLog' because it creates members of the following IDisposable types: 'HttpClient'. If 'HttpLog' has previously shipped, adding new members that implement IDisposable to this type is considered a breaking change to existing consumers. Gigya.Microdot.Fakes C:\Git\Microdot\Gigya.Microdot.Fakes\HttpLog.cs 36 Active