giantswarm / aws-operator

Manages Kubernetes clusters running on AWS (before Cluster API)

Home Page:https://www.giantswarm.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Host cluster CIDR block can be nil when creating security group rules

rossf7 opened this issue · comments

In local testing the host cluster CIDR block can be nil which causes a panic. For now an error is returned if this occurs. Retry logic for the VPC peering connection may be needed to fix this.

Is this issue still valid? Is it solved or will it be solved by the use of cloudformation?

Closing. I've only seen this locally and will be fixed by cloud formation.

Raising to postmortem. Customers affected.

@corest please take this to your team.

Fix is merged. We now retry getting the VPC peering connection if the accepter and requester CIDRs are not yet populated.

After the max backoff if the data is not present the current execution of the operator will fail. But this is the same as the previous error check which failed without a retry.