`bottom_footnotes` config adds unwanted square brackets to footnote references

[Abdul-Rahman Sibahi]

Hello.

The square brackets around footnotes references applied when bottom_footnotes config is set is not documented anywhere, and honestly, looks ugly. They should either be removed or made as a config option.

The removal is a tiny change I made in my fork here here. I did not want to create a pull request, however, without clearing that it is ok to do so.

The additional config option would be a bit more involved: Upgrade the bottom_footnotes config to an enum with Default, Bottom, Github-style etc.

[Vincent Prouillet]

@totikom any idea why the brackets are there?

[Eugene Lomov]

@totikom any idea why the brackets are there?

They were initially used in "gh-style", but they can be safely removed.
The patch by @asibahi is a correct way to do it.

[Vincent Prouillet]

They don't seem used by GH itself so I think a PR to remove them is fine

[Eugene Lomov]

They don't seem used by GH itself so I think a PR to remove them is fine

Yep, it is totally ok.