Support uploading Go source code with a release
eric opened this issue · comments
Summary
I would like to see support for uploading Go source code with a release.
Motivation
We are not able to package the source code with our binary but still would like to have the improved experience of seeing the source code in Sentry.
Additional Context
We ship the binary to customers and do not want to provide them with the source code.
We discussed this internally and would consider adding this in the future. I can't give you any timeline, though.
Not having this greatly reduces the usefulness of Sentry for Go for us. It involves manually looking at the files in an editor, because there is no linking to github, no context, and the stack frames as they are listed make it difficult to capture both the file name and the line number at the same time.
You would need to create a source bundle and upload it at compile time. And then you would also need to upload debug files, which is odd in Go, that include a debug ID so we can map your code to the event in Sentry. None of this is currently supported in Go, so it takes different teams to get this going. Hence it's unlikely that we will get to this in a short timeframe.
Can you expand on the stack trace layout? What exactly bothers you with the visuals?
Not having the format of <file>:<line> means that I can't paste it into a VSCode Quick Open dialog or anything like that.
Honestly I've said this all over the place, but it would just be really nice if I could map some file/package locations to GitHub URLs to at least link to the code. It's terribly frustrating to have literally nothing that can easily get me to the code to look at what's going wrong.
None of this is currently supported in Go, so it takes different teams to get this going. Hence it's unlikely that we will get to this in a short timeframe.
I understand that it doesn't sound like you have many customers that you know of that are shipping Go binaries to places that can't have access to the source code, but not having this functionality severely limits the usefulness of the product to those of us who do. Is this on the radar of the wider PM org to prioritize this?
I filled part of this as getsentry/sentry#59030 and pinged the PM involved. I totally agree btw, this is crazy bad!
Is this on the radar of the wider PM org to prioritize this?
Yep, it is. But as you also mentioned, we don't have many customers with this use case 🙁
But I do have a project where it bothers me to include my source code in the docker container to get source context working, so rest assured, this is not just a you issue!
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
It sure would be great if someone could handle this before the bot closes it.
We did ship an update to our stack trace view, which now lets you map your stack trace to GitHub without the need for having source context availiable.
