getmoto / moto

According to AWS Documentation, create_platform_endpoint is idempotent, so if an endpoint is created with the same token and attributes, it would just return the endpoint.

I think moto has that logic implemented. For example, the following snippet will work as expected in moto.

client = boto3.client("sns")
token = "test-token"

platform_application_arn = client.create_platform_application(
    Name="test", Platform="GCM", Attributes={}
)["PlatformApplicationArn"]

client.create_platform_endpoint(
    PlatformApplicationArn=platform_application_arn, Token=token
)
client.create_platform_endpoint(
    PlatformApplicationArn=platform_application_arn,
    Token=token,
    Attributes={"Enabled": "true"},
)

However, I think the logic is not correct when we create the endpoint with the default attributes. The following example code will raise an exception in moto but will pass without problems in real AWS.

Example code:

client = boto3.client("sns")
token = "test-token"

platform_application_arn = client.create_platform_application(
    Name="test", Platform="GCM", Attributes={}
)["PlatformApplicationArn"]

client.create_platform_endpoint(
    PlatformApplicationArn=platform_application_arn, Token=token
)
client.create_platform_endpoint(
    PlatformApplicationArn=platform_application_arn, Token=token
)

Expected result: The last call to create_platform_endpoint should not raise an exception

To add further details, I think the problem is the default value in this line:

moto/moto/sns/models.py

Line 682 in 9713df3

attributes.get("Enabled", "").lower()

Moto version: 5.0.5

Hi @DiegoHDMGZ, thanks for raising this - looks like AWS indeed allows this call. I'll open a PR with a fix soon.

SNS: `create_platform_endpoint` is not idempotent with default attributes