Language name in language switcher plugin not displaying correctly
yankl opened this issue · comments
I have two languages setup on my site: English and Yiddish. I'm using the language switcher plugin. Right now the plugin (with configuration language_display: long ) displays the following:
whereas I believe it should display the following:
The issue, as I understand it, is that the plugin uses the function Grav\Common\Language\LanguageCodes::getNativeName to get the native name, and Yiddish ('yi') is missing from the language codes. (In fact, it used to be there, but it was lost, presumably inadvertently, in a commit d7f286f in 2016.)
Over a year ago I submitted a pull request which adds one line of code to add back Yiddish to the language codes: #3336. However, it's been ignored (cf. my lament here: #3455) .
I realize I can just copy over the template from the plugin to my theme and fix it there by hardcoding the language name. I just thought I'd make one last attempt at adding my favorite language to Grav so it can work out of the box.
This issue has now been resolved as of Grav v1.7.34 by the merging of my pull request #3336. Thanks! 😄