DAL: postgres connections not being closed
mmiller1 opened this issue · comments
noticed something interesting after building the code in the main branch: on every message sent in a channel that gort is in, a dangling connection is left open in postgres, eventually leading to the max_connections parameter being reached, which consequently causes gort to respond to every message in the channel with an error.
I think there are potentially two issues here:
the connections being left open is obviously one, and potentially the second being that we might not want gort automatically responding to DAL related errors in the chat service, this is quite noisy and a real nuisance to people not familiar with the bot itself.
I've identified the issue. A patch will be released today.
I've identified the issue. A patch will be released today.
It's taking longer than I hoped. The fix can be expected this weekend.
a dangling connection is left open in postgres, eventually leading to the max_connections parameter being reached, which consequently causes gort to respond to every message in the channel with an error.
I'm considering this to be the primary issue in this ticket. It's fixed by #208.
we might not want gort automatically responding to DAL related errors in the chat service
This is also true! Let's open a separate issue for this one
#208 is merged!