Reviewers not updated with spr --update-message
schrockn opened this issue · comments
Hello! First of all thanks for the wonderful tool.
I frequently have the workflow where I make an initial commit and then want to update the set of reviewers later. I'd love to be able to do this via the commit message just like I can do on the initial commit. I prefer using the commit message as the source of the truth rather than the GitHub UI
However after the initial commit it appears that the Reviewers: field is ignored. Another indication of this is that if you edit the Reviewers field only and run spr diff --update-message it says there is no update necessary.
If this is deliberate decision, no worries and feel free to close.
See a test PR: dagster-io/dagster#10751
Not a deliberate decision, more like a blind spot in the implementation. Thanks for raising this!
I don't know when/if I find time to do something about it myself, but PR's welcome.
Ok great thanks for the context. I might look at taking this on over the Christmas break as an excuse to learn some Rust.