getbase / base

Base - A Rock Solid, Responsive CSS Framework built to work on all devices big, small and in-between.

Home Page:http://getbase.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

!default in sass variables

Ziao opened this issue · comments

commented

May I suggest using !default for all the variables in Base? This way, it's easy to overwrite them in your own file, without having to modify a dependency for your project. It won't alter any of the functionality but makes the lives of those importing the scss code (for example, from a bower install) much easier.

See http://sass-lang.com/documentation/file.SASS_REFERENCE.html#variable_defaults_

So:

$base-background-color:                         #fff !default;
$base-font-family:                              sans-serif !default;
$base-font-size:                                16 !default;

Hey Nick!

Thanks for recommending and explaining this! - I will definitely be putting this into the Base 2.8 release.

I will notify you once released.

Thanks again!

Cheers,

Matthew

Hey Nick,

The updates have been rolled out in the latest build (Base V2.8.0).

Cheers!

Matt