geohot / minikeyvalue

A distributed key value store in under 1000 lines. Used in production at comma.ai

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

MD5

tegk opened this issue · comments

There is no requirement for a cryptographic hash to use, right?
Let us use a non cryptographic hash then like xxhash or murmur3 as they are much faster.

I am happy to send a PR in case we agree :-)

We already have this in use with MD5, so can't really change. Reason for the MD5 decision is I'm not sure speed is such a concern, and I know I can trust a cryptographic hash.

Ok, I understand.