geo-fluid-dynamics / phaseflow-fenics

Phaseflow simulates the convection-coupled melting and solidification of phase-change materials.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why does instantiating a FEniCS solver require the problem as an argument?

agzimmerman opened this issue · comments

The interface to fenics.AdaptiveNonlinearVariationalSolver (and also to fenics.NonlinearVariationalSolver or fenics.LinearVariationalSolver for that matter) makes it difficult to separate the problem and solver objects. We would have more design freedom if problem was an argument to solve. Essentially I'm recommending dependency insertion.