geerlingguy / ansible-role-nginx

Ansible Role - Nginx

Home Page:https://galaxy.ansible.com/geerlingguy/nginx/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Extra modules are not loaded (nginx.conf template miss modules-enabled include)

ncharlot opened this issue · comments

In default Debian package nginx.conf we have:

include /etc/nginx/modules-enabled/*.conf;

package source: https://sources.debian.org/src/nginx/1.18.0-4/debian/conf/nginx.conf/

This instruction is missing in the template causing that no extra module is dynamically loaded.

commented

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

commented

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

Too bad this just got closed - I have the same issue.

@eengstrom I use this workaround (for instance to load libnginx-mod-http-headers-more-filter):

nginx_extra_conf_options: |
  # Fix NGiNX modules load https://github.com/geerlingguy/ansible-role-nginx/issues/200
  include /etc/nginx/modules-enabled/*;

@ncharlot - thanks - was just about to the same point. Will take your workaround.

/reopen

@geerlingguy: this line is in the stock nginx.conf file:

include /etc/nginx/modules-enabled/*.conf;

Is there a reason you left it out?
Also, if I were to submit a PR to fix this, would you take it?