geerlingguy / ansible-role-gitlab

When setting the gitlab_registry_external_url it appears that it is not actually taking effect.

Expected Behavior:
gitlab.rb file includes:

# GitLab registry.
registry['enable'] = true
registry_external_url = "https://gitlab.example.com:4567"
registry_nginx['ssl_certificate'] = "/etc/gitlab/ssl/gitlab.crt"
registry_nginx['ssl_certificate_key'] = "/etc/gitlab/ssl/gitlab.key"

Actual Behavior:
gitlab.rb file includes:

# GitLab registry.
registry['enable'] = true
registry_external_url "https://gitlab.example.com:4567"
registry_nginx['ssl_certificate'] = "/etc/gitlab/ssl/gitlab.crt"
registry_nginx['ssl_certificate_key'] = "/etc/gitlab/ssl/gitlab.key"

I believe this is just an issue with the template/gitlab.rb.j2 file.

I will try to fix this myself and open a PR soon if time allows.

Nevermind, looks like that's how it's supposed to be so I have a different issue on my end.

gitlab_registry_external_url not taking effect