Performance
stefanpenner opened this issue · comments
what can we do to make this easier and most maintainable?
- broccoliaddons.com
Maybe we should move strings and styles to the environment file that way is really easy to change. Also when code changes are made you can just merge and it should just keep working if you ignore the environment file.
@gcollazo i wonder if this project should just host both. Roll our improvements to both at the same time. can't imagine it would be hard
@stefanpenner I'm not really sure I understand what you mean. Have both lists of plugins on the same site? Maybe have the same app look at the domain and swap the strings and API url?
Maybe have the same app look at the domain and swap the strings and API url?
yes (just a thought)
I'll spend sometime working on this over the weekend. But right now, my main priority is fixing the initial render time. Any suggestions?
@gcollazo outside of ember, the number of 404's from travis images is pretty rough. Maybe we need to defer that until it is visible or the user interacts with it.
https://github.com/eviltrout/ember-cloaking may be interesting?
We can also use list-view, I have experimented with it working with the windows scroll.
I know @tim-evans uses that sort of setup in his app, maybe he can tell us if its a good idea or not.
I guess it depends on the experience we want to give?
We are working on overall ember performance, which will continue to improve. But at some point I believe we will not be able to render the entire list, regardless how fast ember is.
My experience has been positive using list-view in the window body. The downside will be a fixed height approach.
Before trying list-view I want to just render the first 50 items and have next and previous buttons to navigate the list.
Yes! just did some testing and it looks like pagination is the way to go. That way I can just render 50-100 items at a time. Performance is a lot better and from a UX standpoint it makes more sense to have shorter pages.
I will try to refactor the app over the weekend.
Awesome site - I love visiting daily. However, I want to give some honest user feedback: I'm not a fan of the pagination. I'd much rather take a 1s hit to initial load time and be able to scroll through countless addons.
If you decide to keep the pagination it should an least scroll to to top of the page when showing a new set of results.
Happy to lend a hand if I can help.
@sir-dunxalot took your suggestion now the page will scroll to the top of the packages table when your change pages.
Closed and moved the original topic to #32