gchq / sleeper

A cloud-native, serverless, scalable, cheap key-value store

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Review whether sleeper.subnets property can be editable

gaffer01 opened this issue · comments

Background

The property sleeper.subnets is not editable.

Description

A test was performed: The code in CommonProperty was changed so that the property sleeper.subnets is marked as editable and requires a cdk deploy when changed. Then the admin client was used to add a subnet on to the list of subnets. This seemed to work - after the change system tests and compactions were running on both the old and new subnets.

Analysis

We might be able to mark the subnets property as editable. We can test what happens if this property is changed whilst tasks are running (there may be 2 cases - one where tasks are running in a subnet that is removed from the list, and one where a new subnet is added).