gbdev / rgbds

Rednex Game Boy Development System - An assembly toolchain for the Nintendo Game Boy and Game Boy Color

Home Page:https://rgbds.gbdev.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Warning/error function refactoring

Rangi42 opened this issue · comments

src/error.cpp defines warn, warnx, err, and errx. We only use errx. All warnings are currently manually coding their "warning: " prefix; we should use warnx. Also, instead of the err variant, we manually pass strerror(errno) (if that's technically necessary, then we should remove err and warn as useless).

This was a misunderstanding due to code coverage output that hadn't triggered warnings/errors.

Yeah, some of the formatting is inconsistent, especially across tools; but I intend to have that fixed in rsgbds by making all of that common anyway.