Some ASM templates do not compile anymore
ISSOtm opened this issue · comments
Recent RGBDS updates have made breaking changes to the language, leading to some libraries not working anymore.
For example, the first link in the "Boilerplates and libraries" section, which is the first one a new ASM programmer is going to try, fails to build.
What should we do?
- Poke upstream
- Move them down
- Note which RGBDS version (and other deps?) these entries require
- Remove those entries outright
It's always worth poking upstream, about 1/10 times you'll get someone who will fix something in a few days, saving you having to do something else later.
I suggest to:
- Remove them from the list (or move them to MORE.md)
- Open an Issue upstream
- Open an Issue here specifying which repository has been moved and waiting to be updated for the new API (to get them back into the main list)
In any case, it's time for RGBDS to provide some of that stuff "officially" and from their docs
What stuff? The changelogs are very clear about breaking changes, since we're plenty aware how much they break. (Besides, unless impossible, we deprecate behavior that will be changed, so that a smooth transition is possible.)
ping @avivace
What stuff? The changelogs are very clear about breaking changes, since we're plenty aware how much they break. (Besides, unless impossible, we deprecate behavior that will be changed, so that a smooth transition is possible.)
I meant "RGBDS should provide some officially maintained templates". Aside from this, my solution here is in the previous message
This role is essentially fulfilled by gb-boilerplate and gb-starter-kit, which I keep up to date.
@avivace Shouldn't this be re-opened until the templates have been triaged?
@avivace Shouldn't this be re-opened until the templates have been triaged?
This issue concerns the actions to be taken to handle this kind of resources. An approach has been decided (see my comment), so now you are free to follow it for each of the interested entry.
Right, I'll document that procedure in the wiki.