Remove VAPID private key from github

Question

Remove VAPID private key from github

jeznag opened this issue 7 years ago · comments

Jeremy Nagel commented 7 years ago

https://github.com/gauntface/web-push-book/blob/master/src/demos/node-server/index.js#L18

In the book, you say, keep your private keys private :P

Matt Gaunt-Seo · Answer 1 · Wed Mar 22 2017 02:47:17 GMT+0800 (China Standard Time)

Do as I say - not as I do ;)

At the end of the day - the demo server is not hosted anywhere and I'd like people to be able to play with the demo with as little friction as possible.

I should add a comment saying this should be private - but open to other / better ideas ;)

Jeremy Nagel · Answer 2 · Wed Mar 22 2017 09:00:36 GMT+0800 (China Standard Time)

I actually tried using those keys out of laziness and got a really confusing error that didn't seem related. Took me about an hour to figure it out lol. Might be safest to force people to generate their own.

…

On 22 Mar 2017 5:47 am, "Matt Gaunt" ***@***.***> wrote: Do as I say - not as I do ;) At the end of the day - the demo server is not hosted anywhere and I'd like people to be able to play with the demo with as little friction as possible. I should add a comment saying this should be private - but open to other / better ideas ;) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_KijcAH_Hfw3oxRgurbdSyvKT3XsVvks5roBs2gaJpZM4Me1zR> .