How to update the data in source_data/armors/armorset_*.csv?
polarmora opened this issue · comments
How to update the data in source_data/armors/armorset_*.csv?
I run the code in merge.py and wrote some my own codes to do more process, but then I find the data of armorset was not updated like other files. How can I update them ?
Unfortunately armorset is not read from the binary, and needs to be hand edited. The reasoning is that the ingame data has a lot of dummy data and currently there's no mechanism to separate dummy data and real data for armor. In the current implementation the armorset list is a driver for the rest of the process (armor data is populated by iterating over the armor sets).
Should the condition for valid armor pieces be found, its probably as simple as grouping the armor by the armor series. It might be the same as weapons where it needs to have an existing crafting recipe with all item entries having valid names, but I haven't tested.
BTW, should anyone with experience with mhworld modding wish to improve the binary module, it is open. I don't know much of the binary files and am going off an existing repository to figure it out.
Gala suit has been added, if that's what you were trying to process.
Maybe a Blacklist is here the better option, if we don't find something automatic thing?
Unfortunately, there's too many invalid entries for a blacklist to be sustainable. A whitelist ends up being easier. I might give this another shot in the future though where only the name of the armor series is needed as a whitelist, or create a new predictor for whether its valid or not.
Blacklists will eventually exist in the pipeline for unreleased data though. Really want to avoid leaking data via the DB.
@rising-fallmoon armorset_base is now updated, but not armorset bonus. It still uses the existing names in armorset_base as a key, but the rest of the data (including armor names) are now filled out.
I'd do armorset bonus but I don't know how the associations work and luckily there aren't that many unique armorset bonuses.
The base is required because the idea is to eventually allow console only armor pieces, and those will have to be manually added. So we can't override armor pieces. Also the order flag in the ingame binaries don't seem to be what actually lead to the current ordering.