Members organisation can be added
Yuvraj-kadale opened this issue · comments
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The users who are the admin of organizations are only displayed
Describe the solution you'd like
A clear and concise description of what you want to happen.
users as a member in the organisation can be added
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
issue #50
Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.90. Please mark this comment with
Links: app homepage, dashboard and code for this bot.
To display the organizations of any user, we will need to refer to a different API endpoint. Currently, we use data.company for getting the company, but that's something that doesn't have the complete information. And it's not necessarily linked to the organization account either.
I think we should refer to a different endpoint for the organizations, to be specific https://api.github.com/users/${username}/orgs to get the organization data, that way we can put more and better info.
@garimasingh128 can we do this way? If yes, I would like to take this issue.
Yeah you would need a different endpoint for it. Assigning you. Report within a week. Also, you can use cards, some highlights or just general bullets to displays the orgs. All the best!
@garimasingh128 This is what I have done. How does it look?
I also tried using anchor tags, but I don't know why they were all only in black color. I think there is some CSS property set for it which we might have to change, or maybe we can add some new class for this. Do we need an anchor tag to link names with the GitHub profiles of the organizations? We aren't getting links for those from the endpoint but we have login id from that so we can make it.
I think instead of showing them in a column just show the logos in a row just like how Github shows and add the anchor tag to the image. For now, you can remove the org names and just show the logos. Also, you have to remove the default property in CSS of anchor tags to not show it in black.
@garimasingh128 ok.
I have made changes like this and the logos are placed in the anchor tags:
Ya it looks good!
Maybe you can try with someone who has many organizations and see how it looks. It should not look too crowded!
@garimasingh128 yep it works fine
I will make PR if it seems good?
Looks good. Make a PR 👍🏽