gardener / machine-controller-manager-provider-azure

This repository is the out of tree implementation of the machine driver for Azure cloud provider

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make `lun` field optional in Azure provider.

hardikdr opened this issue · comments

What would you like to be added: With the support of multiple-worker disks in gardener/machine-controller-manager#397 , luns have been made required field in azuremachineclass. We might want to consider making it optional for better UX.

Refer to the comment for related discussion.

cc @dkistner

This has been handled in MCM-Provider-Azure as well. Here are the lines of code for handling the disks and even in the MachineClass ProviderSpec, here the LUN is an optional field.

@dkistner Could you please take a look and help me decide if this issue can be closed?

As the lun can be specified optionally I guess it is ok to close.