Add Container Deployer Support for "component create" CLI command
In-Ko opened this issue · comments
Description
Similar to the existing support of the helm-ls and manifest deployer, the CLI must also support the container deployer. So similar to the other deployers, it should be possible to add a container-based deployment via the CLI to a component.
This is crucial for some of the Gardener-Components.
Done Criteria
- All Features implemented
- Code has been reviewed by other team members
- Unit Tests created for new code
- Integration Test Suite updated (if applicable)
- Internal technical Documentation updated
- Enduser Documentation updated (if applicable)
- Successful demonstration in Review
- basic functionality implemented and documented
- missing
- integration tests
- handling of image pull secrets
- description/example for data in blueprint, blueprint and component descriptor reference in deploy item
- adapt description of container deployer in landscaper project
Current State: See above comment
So all the missing work mentioned above is done ?
- integration tests
- handling of image pull secrets
- description/example for data in blueprint, blueprint and component descriptor reference in deploy item
- adapt description of container deployer in landscaper project
Sure. That's the reason why I marked all done criteria accordingly :-)
documentation with an example could be found here: https://github.com/gardener/landscapercli/blob/master/docs/commands/container_deployer/add_container_di.md
- Remaining docu for the CLI & for the container deployer in the landscaper docu has been created and tested
- Unit tests & Integration tests have been created