Giters

gardener / gardener

Homogeneous Kubernetes clusters at scale on any infrastructure using hosted control planes.

Home Page:https://gardener.cloud

Repository from Github https://github.comgardener/gardenerRepository from Github https://github.comgardener/gardener

Drop GRM `TokenInvalidator` controller when we drop support for shoots with version <= 1.26

Kostov6 opened this issue · comments

commented

How to categorize this issue?

/area quality
/kind cleanup

What would you like to be added:
As in 1.27 LegacyServiceAccountTokenNoAutoGeneration becomes LockToDefault: true ref, after #10339 we can drop related code to the TokenInvalidator controller

Why is this needed:
Drop unneeded code

commented

@rfranzke, can you also confirm that it is safe to drop the TokenInvalidator controller and webhook from GRM after #10339? Thanks in advance!

commented

/assign Kostov6

commented

@Kostov6 @ialidzhikov Yes, after we drop support for Kubernetes < 1.27, it should be safe to also drop the TokenInvalidator completely. Thanks for keeping track of this! 🙇🏻

commented

I can do it as a part of #10339. Just need to cherry-pick d06a371.
/assign

commented

Added it as a task in #10339.
Let's close this one.
/close

commented

@shafeeqes: Closing this issue.

In response to this:

Added it as a task in #10339.
Let's close this one.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

commented

We still require support for kubernetes version 1.26. We have a product that is working to become compatible with version 1.27, but it's still a work in progress.