messages on canvas not removable

Question

messages on canvas not removable

chpech opened this issue 4 years ago · comments

Hi Manuel,
I am implementing an interface for coco2p to francy and came upon a problem when removing messages using a callback. I attached a minimal example for the explanation:

tstfrancymsg.g.gz

When adding msg1 and immediately removing it, it remains on the screen.
When adding msg1 and msg2 and then removing msg1 the msg1 is removed. Trying to remove msg2 afterwards remains unsuccessful.
When adding msg1 and msg2 and the remove both at once, nothing happens
When adding msg1 and remove it and the add msg2, then msg2 overwrites msg1

It seems that francy is not always redrawing the screen when removing a message.

Best,
Christian

Manuel Martins · Answer 1 · Mon Apr 13 2020 18:07:52 GMT+0800 (China Standard Time)

Hi Christian,

I remember doing something hacky to handle messages, because the communication between the frontend and the kernel is not fully duplex. I mean, when a user click to close a message dialog, it does not propagate to the kernel, hence when it gets rendered again in the browser D3 will have the previous state and not render it again (I think this was the design I chose).

I'll replicate with you instructions and try to fix accordingly.

Thanks for your feedback!

Manuel

Christian Pech · Answer 2 · Tue Apr 14 2020 17:12:06 GMT+0800 (China Standard Time)

Dear Manuel, thank you very much for your quick reaction. Just to clarify perhaps a bit more, what I try to achieve: I would like that one callback opens a series of messages and another callback removes these messages once more. The user may or may not choose to close one or another message herself, but this is not of concern to the package. The trouble is, when the second callback removes all messages that it knows of (and these are usually all messages), then the messages get removed on the gap-side, but not on the screen. If the callback removes just one message from several, then the message vanishes also from the screen. It seems that only when it tries to remove all messages, then no redraw happens. Once more, thank you for looking into this. Best regards, Christian

…

-- Sent from Canary (https://canarymail.io)

On Montag, Apr. 13, 2020 at 12:08 PM, Manuel Martins ***@***.*** ***@***.***)> wrote: Hi Christian, I remember doing something hacky to handle messages, because the communication between the frontend and the kernel is not fully duplex. I mean, when a user click to close a message dialog, it does not propagate to the kernel, hence when it gets rendered again in the browser D3 will have the previous state and not render it again (I think this was the design I chose). I'll replicate with you instructions and try to fix accordingly. Thanks for your feedback! Manuel — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#49 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADFXUQJNGBRQA5B7LPX37DRMLQAJANCNFSM4MFLAJ5Q).

Manuel Martins · Answer 3 · Sat Apr 10 2021 22:13:27 GMT+0800 (China Standard Time)

I'll try to look into this for the next release.

Manuel Martins · Answer 4 · Mon Jan 23 2023 05:42:06 GMT+0800 (China Standard Time)

Fixed all the bugs reported on this issue plus implemented a close message callback for all messages created (when a message is closed on the GUI it will destroy it on gap as well).