galadril / Xam.Shell.Badge

A small plugin to ease the use of badges on Shell Bottom Bars

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Badge doesn't appear when using CustomShellRenderer (both, iOS and Android)

sahil-khanna opened this issue · comments

I'm using a CustomShellRenderer for both iOS and Android. The issue is as below

  • When a CustomShellRenderer is used, the badges do not appear.
  • Commenting the below line in the CustomShellRenderer displays the badges
    [assembly: ExportRenderer(typeof(FB.Views.IssuerStartPage), typeof(IssuerShellRenderer))]

Can anyone guide me to display the badges along with a CustomShellRenderer

@sahil-khanna I also facing the same issue on both iOS and Android with custom shell renderer

there is my renderer and in BottomTabBar m doing my stuff.
public class AppShellRenderer : ShellRenderer
{
public AppShellRenderer(Context context) : base(context)
{
}

    protected override IShellBottomNavViewAppearanceTracker CreateBottomNavViewAppearanceTracker(ShellItem shellItem)
    {
        return new BottomTabBar(Element);
    }
}

@sahil-khanna @MNADEEMCH @galadril Have you found any workaround for this issue ?

I have the same problem. Binding property do not refresh when called on property changed, but if i set property before constructor calls then badge shows. Can't resolve this problem

@sokrog Instead of using this nuget, use the workaround code from @galadril in below link. That worked for me.
xamarin/XamarinCommunityToolkit#517 (comment)

You may implement the same logic as this library does by visiting sources and adding related code into the necessary platform renderers.

Also, @sokrog, check out my #24 PR for easier and more straightforward implementation of Badges for Android.

You may implement the same logic as this library does by visiting sources and adding related code into the necessary platform renderers.

@SnowPowerCore, I have already resolve my problem by adding related code to my project, thanks all =)

Looks like i've issues with the latest nuget because of my build setup..

@galadril Is this issue fixed now?

@galadril Do you recall what you changed in your build?