reactHotLoader.register(comlink.wrap(worker)) cause comlink.wrap error
magicdawn opened this issue · comments
Tao commented
Description
source
import SomeWorker from './some.worker.js' // via worker-loader
import * as comlink from 'comlink'
const someWorker = comlink.wrap(new SomeWorker())
generated js
reactHotLoader.register(someWorker, blabla)
What you are reporting:
the register
body try to get some props on someWorker, produced by comlink.wrap
it's a Proxy
. and errors like
register
logic wantssomeWorker.name
- with
comlink.expose(obj)
, comlink callobj.name[Symbol.toPrimitives]()
Expected behavior
be smart, don't wrap everything
Actual behavior
the babel plugin is register
ing all identifiers
Environment
React Hot Loader version:
does not matter.
Tao commented
tried cold
, that does not prevent reactHotLoader.register()
code
Anton Korzunov commented
Easy to reproduce 👍, I'll handle it.