Giters

gabrielrcouto / php-svm

Pure PHP Support Vector Machine

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SplFixedArray

wmelton opened this issue · comments

commented

Great job on the implementation!

For larger training jobs, wondering if it's worthwhile to investigate implementing SplFixedArray in to the class? While I'm not sure of the PHP7 impacts, for PHP < 7 this resulted in a memory reduction of 144 bytes per array element to 56 bytes per array element.

If you were working with 50M data points total, this would reduce the memory requirements from 7.2GB to 2.8GB.