AbstractDataSource methods access level

Question

AbstractDataSource methods access level

adam-leitgeb opened this issue 6 years ago · comments

Methods in AbstractDataSource are not open so in case we need to change / add something to current implementation, we can't. I wanted to ask what's the reason for such decision? Can I make PR with open methods?

Matěj Kašpar Jirásek · Answer 1 · Mon Oct 22 2018 18:54:53 GMT+0800 (China Standard Time)

I agree this could be required. Do you have the reason/use-case for it so I understand how this could help?

Adam Leitgeb · Answer 2 · Mon Oct 29 2018 13:31:40 GMT+0800 (China Standard Time)

I needed to call method on table view's instance every time cellForRowAtIndexPath: is called. However, I realized it's not good at all and found different solution.

I decided to close this issue because I can't think of any other scenario when we might need these public methods to be open.

Thank you

I'm sorry for late reply. I haven't received notification.

Matěj Kašpar Jirásek · Answer 3 · Mon Oct 29 2018 15:48:38 GMT+0800 (China Standard Time)

OK, thanks for the information.