Cannot install project dependencies
montanarograziano opened this issue · comments
Describe the bug
I was trying to setup the project following the Contributing section in doc, but found errors during dependency install.
To Reproduce
- Clone the repo
- Run
rye sync --features=dev
Expected behavior
Dependencies installed without issues.
Screenshots
Desktop (please complete the following information):
- OS: MacOs
- Python Version: Tried 3.8, 3.9 and 3.12
Additional context
Removing rust-toolchain.toml makes the issue disappear, but causes errors during unit tests.
Ciao Graziano, thanks for opening the issue.
@abstractqqq do you think it'd be safe to move the rust-toolchain to nightly? v1.79 should be out in two days. We'd need to update the tests again.
@montanarograziano can you show what test fail? If you remove the rust-toolchain is removed, rustup should just use stable rust (1.78) which is older than the version that TQ used to write the code.
Oddly enough, I cannot reproduce the errors on the test anymore 😅 I think it was something you fixed in the last commits. Tried different python versions and all tests pass.
Last time we updated rust compiler and package versions. So this should be solved.
Last time we updated rust compiler and package versions. So this should be solved.
I don't think that's the case: they are trying straight from master.
Rust 1.79 is out today! You can give this another shot, I guess (?):
1. Remove .rust-toolchain.toml
2. rustup update stable
3. Run install command
The toolchain file will switch to nightly rust I think
The toolchain file will switch to nightly rust I think
I think this might be it! I could not compile on stable release so I pushed a commit switching to nightly. Could someone try to see if it builds? Next week I will try to find the time to split functime-rs from python.
The toolchain file will switch to nightly rust I think
I think this might be it! I could not compile on stable release so I pushed a commit switching to nightly. Could someone try to see if it builds? Next week I will try to find the time to split functime-rs from python.
Just tested on 3.12 and I confirm I can build and test correctly. Thank you!