Wrong git version

Question

Wrong git version

fulldecent opened this issue 7 years ago · comments

William Entriken commented 7 years ago

There is an error here somehow

https://github.com/fulldecent/lightning-sites/blob/master/lib/lightning_sites.rb#L84-L86

William Entriken · Answer 1 · Wed May 03 2017 04:16:34 GMT+0800 (China Standard Time)

Specifically with including or not including the *

William Entriken · Answer 2 · Sun Apr 08 2018 07:29:04 GMT+0800 (China Standard Time)

@ilyalyo Can you please double check this?

William Entriken · Answer 3 · Fri Feb 08 2019 00:16:50 GMT+0800 (China Standard Time)

@Raza403 Can you please take a look at this

William Entriken · Answer 4 · Wed May 22 2019 03:18:36 GMT+0800 (China Standard Time)

Now relevant code is at https://github.com/fulldecent/lightning-sites/blob/master/lib/lightning_sites.rb#L86-L87

Ahmed Raza · Answer 5 · Thu May 23 2019 02:08:13 GMT+0800 (China Standard Time)

@fulldecent How / Where can I see the error?

William Entriken · Answer 6 · Thu May 23 2019 04:43:27 GMT+0800 (China Standard Time)

When building a site it should add an asterisk (*) to VERSION if the working directory is dirty. If the working directly is not dirty then the asterisk should not be added.

But currently the asterisk is being added every time.