fulcrologic / fulcro-template

A sample project that could be used as a starting point for a Fulcro 3 project.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Yarn works but NPM does not

darren-fhf opened this issue · comments

According to the directions, you can either use "yarn install" or "npm install"

However, using npm, it errors out due to dependency mismatches; for example:

While resolving: app@1.0.0
Found: react@17.0.1
node_modules/react
  dev react@"^17.0.1" from the root project

Could not resolve dependency:
peer react@"^0.14.0 || ^15.0.0 || ^16.0.0" from react-icons@2.2.7
node_modules/react-icons
  dev react-icons@"^2.2.7" from the root project

Using yarn works and warns about these problems:

warning "react-grid-layout > react-resizable@1.11.0" has incorrect peer dependency "react@0.14.x || 15.x || 16.x".
warning "react-grid-layout > react-resizable@1.11.0" has incorrect peer dependency "react-dom@0.14.x || 15.x || 16.x".
warning " > react-icons@2.2.7" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".
warning " > react-icons@2.2.7" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0 || ^16.0.0".
warning "react-icons > react-icon-base@2.1.0" has unmet peer dependency "prop-types@*".
warning " > reakit@0.11.2" has unmet peer dependency "prop-types@^15.0.0".
warning " > reakit@0.11.2" has incorrect peer dependency "react@^16.3.0".
warning " > reakit@0.11.2" has incorrect peer dependency "react-dom@^16.3.0".
warning "reakit > constate@0.7.2" has incorrect peer dependency "react@^16.3.0".
warning "reakit > constate@0.7.2" has incorrect peer dependency "react-dom@^16.3.0".
warning "reakit > styled-components@3.4.10" has incorrect peer dependency "react@>= 0.14.0 < 17.0.0-0".

I don't know enough about JS to debug this, but a quick-start template that sends me down a dependency rat-hole is not very friendly to new users.

Suggestion: Change documentation to remove or npm install

eventually need to fix package.json...but npm is such a mess. docs updated. Thanks