fukamachi / dexador

A fast HTTP client for Common Lisp

Home Page:http://ultra.wikia.com/wiki/Dexador

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Name Conflict

juliojimenez opened this issue · comments

I believe #147 introduced the following error:

[package dexador.backend.usocket]
     IMPORT DEXADOR.BODY:WRITE-MULTIPART-CONTENT causes name-conflicts in
     #<PACKAGE "DEXADOR.BACKEND.USOCKET"> between the following symbols:
       DEXADOR.BODY:WRITE-MULTIPART-CONTENT,
       DEXADOR.BACKEND.USOCKET::WRITE-MULTIPART-CONTENT

is there a workaround to this? My tests started failing a few days ago. Apologies if this is something trivial, my CL is still in crawl phase ☺️

friendly bump @fukamachi :-)

Are you loading a new version of Dexador in the environment which loaded the older version?
Please restart the Common Lisp process and retry it again.
If not, deleting fasl files may work.

I'm loading it in a GitHub Workflow, which should be a brand new environment on each job run when no caching is configured. However, I am loading my system twice in the Set Up Lisp and Run Test steps. Perhaps I should only do it in Run Test. I'll give that a shot.

name: CI

on:
  push:
    branches:
      - main
  workflow_dispatch:

jobs:
  all_tests_suite:
    name: All Tests Suite
    
    runs-on: ubuntu-latest
    
    strategy:
      matrix:
        lisp:
          - sbcl-bin

    env:
      LISP: ${{ matrix.lisp }}

    services: 
      clickhouse:
        image: clickhouse/clickhouse-server
        ports:
          - 8123:8123
        options: --ulimit nofile=262144:262144

    steps:
      - name: Checkout Code
        uses: actions/checkout@v3

      - name: Set Up Lisp
        uses: 40ants/setup-lisp@v2
        with:
          asdf-system: clickhouse

      - name: Run Test 
        uses: 40ants/run-tests@v2
        with:
          asdf-system: clickhouse
          # coveralls-token: ${{ secrets.COVERALLS_TOKEN }}
          run-tests: |
            (ql-dist:install-dist "http://dist.ultralisp.org/" :prompt nil)
            (ql:quickload :clickhouse-test)
            (asdf:test-system "clickhouse")

It's weird. Dexador's CI is running every day on Actions, but no problems are found.

You're right, if there's anything to be said, Roswell is the simplest way to go when writing CI in GitHub workflows. I just modeled mine after yours and everything is working great.

🤦‍♂️