some command line options like "--alias" drifts on v1
miztch opened this issue · comments
Once upgrading lambroll from v0.14.x to v1.0.0, I found that lambroll deploy with --alias fails with error.
$ lambroll version
lambroll v1.0.0
$ lambroll deploy --alias live --region $AWS_DEFAULT_REGION
2024/02/13 11:12:29 [error] FAILED. failed to parse args: unknown flag --alias, did you mean one of "--alias-name", "--alias-to-latest"?
This might have come to occur because of #315 (replacement of kingpin with Kong).
Also I found following drifts that may be the same between v0.14.7 and v1.0.0.
- on
lambroll init--downloadchanges into--download-zip
- on
lambroll diff--codechanges into--code-sha-256
If these changes are not intended (and if you think it needs to keep compatibility), I would like to create a pull request to fix them same as b80f49e. (fix for --tfstate and --prefixed-tfstate)
@miztch Thank you for the reporting!
I confirmed these flag names changed unintentionally between v0.14.7 and v1.0.0.
I'll check all of the flags from now. Please wait for a little.
I've checked all the flags in v0.14 and found three flags have different names against the auto-generated name from the attribute name.
InitOption.DownloadZip => download
DeployOption.AliasName => alias
DiffOption.CodeSha256 => code
These flags should be named by name:"..." struct tag.
@miztch I can fix this issue, but if you send a pull request, I'm pleased to do accept it.
@miztch Thank you!! v1.0.1 released!
https://github.com/fujiwara/lambroll/releases/tag/v1.0.1