I do not think MemcachedBackupSessionManager.generateSessionId() need to be synchronized.

Question

I do not think MemcachedBackupSessionManager.generateSessionId() need to be synchronized.

GoogleCodeExporter opened this issue 9 years ago · comments

Google Code Exporter commented 9 years ago

I have reviewed the code, and as title. Do you agree?

Original issue reported on code.google.com by qian...@gmail.com on 21 Jul 2015 at 1:41

Google Code Exporter · Answer 1 · Mon Sep 07 2015 16:10:06 GMT+0800 (China Standard Time)

Yes, AFAICS you're right. Probably at the time I wrote this some tomcat session 
manager I used for inspiration had this synchronized so that I just "copied" it.

Original comment by martin.grotzke on 21 Jul 2015 at 8:07

Google Code Exporter · Answer 2 · Mon Sep 07 2015 16:10:06 GMT+0800 (China Standard Time)

So, it could be faster a bit now.:)

Original comment by qian...@gmail.com on 21 Jul 2015 at 10:37

Google Code Exporter · Answer 3 · Mon Sep 07 2015 16:10:06 GMT+0800 (China Standard Time)

Thanks, I pushed the change to master.

Original comment by martin.grotzke on 21 Jul 2015 at 9:43

Changed state: Fixed
Added labels: 1.8.4, Type-Enhancement
Removed labels: Type-Defect