Giters

fsi-open / datasource-bundle

Main purpose of this bundle is to register FSi DataSource Component service and twig datasource rendering functions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Registration of new elastica driver and its extension

chives opened this issue · comments

commented

Basic elastica driver (fsi-open/datasource#59) will be using only plain https://github.com/ruflin/Elastica. Here in datasource-bundle we can extend it to use all features of https://github.com/FriendsOfSymfony/FOSElasticaBundle (finders, transformers, etc.)

commented

Dependencies between bundles smells to me.

commented

This would be only optional but not required dependency

commented

Anyway its still bad idea.

commented

Registration of https://github.com/fsi-open/datasource-elastica-driver will require integration tests with fixture app and vagrant. Transformation from \Elastica\ResultSet to entities and their indexation should also be done in this bundle (instead of fsi-open/datasource-elastica-driver#11)