frinyvonnick / gitmoji-changelog

A changelog generator for gitmoji 😜

Home Page:https://www.npmjs.com/package/gitmoji-changelog

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

No change found error get catched by error reporter

bpetetot opened this issue · comments

Stacktrace

Error: awesomeversion is not a valid semver version.
    at getChangelog (/Users/ben/Developer/gitmoji-changelog/packages/gitmoji-changelog-cli/src/cli.js:138:11)

Environment

System:

  • OS: macOS 10.15.2

Binaries:

  • Node: 10.16.0 - /var/folders/r3/0cp9w8816hlg19fl1tdn9zlc0000gn/T/yarn--1579015569531-0.011564208258418196/node
  • Yarn: 1.21.1 - /var/folders/r3/0cp9w8816hlg19fl1tdn9zlc0000gn/T/yarn--1579015569531-0.011564208258418196/yarn
  • npm: 6.9.0 - ~/.nvm/versions/node/v10.16.0/bin/npm

CLI options

  • _:
  • format: markdown
  • preset: node
  • group-similar-commits: false
  • groupSimilarCommits: false
  • author: false
  • interactive: false
  • i: false
  • release: awesomeversion
  • $0: /Users/ben/Developer/gitmoji-changelog/packages/gitmoji-changelog-cli/src/index.js
  • mode: init
  • output: ./CHANGELOG.md

Project info

  • name: gitmoji-changelog
  • version: 0.0.1
  • description: Some description

This error report was generated with ❤️ by issue-reporter

The end 2 end test is not enough precise:

it('shouldn\'t generate changelog when gimoji-changelog if there isn\'t any changes', async () => {
      await makeChanges('file1')
      await commit(':sparkles: Add some file')
      await bumpVersion('1.0.0')
      gitmojiChangelog()
      await commit(':bookmark: Version 1.0.0')
      await tag('1.0.0')
      const output = gitmojiChangelog()

      expect(getChangelog()).includes(['1.0.0'])
      expect(output.toString('utf8')).toDisplayError()
    })

This is not the only functional error catched. Closed in favor of #176