frinyvonnick / gitmoji-changelog

A changelog generator for gitmoji 😜

Home Page:https://www.npmjs.com/package/gitmoji-changelog

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Throw an error if preset doesn't return mandatory information

frinyvonnick opened this issue · comments

It should throw an error if preset doesn't return mandatory information. Especially if project's current version is missing.

Just be aware that it's a functional error and don't need to be reported with the new unexpected error report.
Maybe give message to "Check the version in the package.json" in case of node preset and also propose to execute the interactive mode.

Sure this is a functional error 😄 I don't understand the point with interactive mode? What do you think of having a generic error to keep preset implementation simple?

I made a mistake, I wasn't thinking of interactive mode but propose to do the command:
gitmoji-changelog 1.0.0 if we cannot retrieve the version.

Indeed a generic message like "Cannot retrieve the version from your configuration. Check it or you can do gitmoji-changelog <version>" can be enough.

That is what I had in mind 👍

Issue #159 is related to this issue

Done in #161