freifunk-darmstadt / gluon-firmware-selector

Firmware selector for gluon router images

Home Page:https://firmware.darmstadt.freifunk.net/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove unsafe-inline javascript

mweinelt opened this issue · comments

The what and why, and how to do it right:
https://developer.chrome.com/extensions/contentSecurityPolicy#JSExecution

Offending:
Mostly onclick/onchange handlers as far as I can tell, nice work!

            <select id="vendorselect"
                    onchange="firmwarewizard.setSearchQuery(this.value); scrollDown();"></select>

Verify against

"It does, however, require you to write your code with a clean separation between content and behavior"

Nagut. War ich bisher zugegebenermaßen einfach zu faul zu, das zu mal zu fixen. ^^