do not wipe /firmwares when new build is invoked
kls0e opened this issue · comments
I just have built the whole 19.07.5 ath79 target for future use and when I run builter again to build a certain snapshot image, /firmwares is wiped. This might only be expected behavior to some of us.
That behavior was introduced by Perry and me in #5. It should also work, to have Line 139 removed. https://github.com/Freifunk-Spalter/builter/blob/d078d15a6836541569b0066759f94bfae2bed26e/build_falter#L139
I don't like that solution, because I don't like to have merged different builds in the same directory. Anyway, this change shouldn't affect anything else of build-infrastructure:
The buildbot would wipe the whole builddirectory anyway by itself, once the build was finished.
@kls0e would you benefit from keeping the images in firmwares/? Then we should increase user-friendliness and keep them.
I somehow assumed they would stay in place, but once we know the directory is going to be wiped, we can just keep it this way. Maybe point users to this behavior somewhere 👍