freeipa / ansible-freeipa

When setting up an IPA replica with ipaclient_no_ntp: true I get the error:

TASK [freeipa.ansible_freeipa.ipareplica : Install - Replica installation test] ***********************************************************************************************************************************************************************************************************
Thursday 09 November 2023  01:50:23 +0000 (0:00:00.019)       0:00:19.524 ***** 
fatal: [ipa02]: FAILED! => {"changed": false, "msg": "NTP configuration cannot be updated during promotion"}

Looking at the line:

ansible-freeipa/roles/ipareplica/library/ipareplica_test.py

Line 520 in f1a6f44

if options.no_ntp or options.ntp_servers or options.ntp_pool:

 # The NTP configuration can not be touched on pre-installed client:
        if options.no_ntp or options.ntp_servers or options.ntp_pool:
            ansible_module.fail_json(
                msg="NTP configuration cannot be updated during promotion")

Shouldn't that be if not options.no_ntp or... as this variable is True when NTP is not being configured.

This only happens when if the replica is already installed as a client

+1. Face similar issue.

IPA Replica install fails when `ipaclient_no_ntp` is set true