free-pdk / pdk-includes

Device Include files for Padauk MCUs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

HAS_* macro names

spth opened this issue · comments

I think the HAS_* macro names have a high risk of conflicting with user names (one can easily imagine a programmer choosing HAS_COMP or HAS_ADC for a macro referring to some feature in their software).
Maybe some kind of prefix could help?

Makes sense.

I just added a _PDK prefix, so HAS_ADC is now __PDK_HAS_ADC.

Does that work?

Fixed with: 4a792b6
and: 79d0ed8