frc-frecon / frecon

An API for building scouting apps for FRC competitions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"FReCon::Controller.could_not_find" does not use model argument.

rye opened this issue · comments

Three options exist that I can think of:

  • Don't make changes.
  • Remove model argument.
  • Change the return value to use the model argument.
    • Perhaps downcase this?

I favor the latter of the three.

The third argument, however, isn't used at all as far as I can tell. It's still good to have it there, though.

Yeah, you can just replace model_name.downcase with model in the method.

Thought so. Closing this issue, branching, and creating a PR.

See #47.