Giters

frc-frecon / frecon

An API for building scouting apps for FRC competitions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Database: Logger Level Attributes Are Not Used

rye opened this issue · comments

commented

As of a75d272, the code in frecon/database that is responsible for modifying the Logger settings is a little odd. I recommend making this a bit more semantic and logical.

First of all, the code checks for the presence of a variable in a configuration, (which works quite well, if I do say so myself 😎) but does not actually do anything with that value.

Second of all, it sets the Logger.level values for Mongoid.logger and Moped.logger, but then reassigns them to fresh Logger's. This effectively overwrites and just uses the default level. Yucky.