fraxken / ebook_nodejs

Ebook - Become a Node.js developer - https://fraxken.github.io/ebook_nodejs/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename and reorder chapters

fraxken opened this issue ยท comments

Hello ๐Ÿ‘‹

In order to be able to generate PDF version, we need to order the folders and files (else they will be concatened in the wrong order).

image

I started the work on the french version. It require to fix all the markdown links.

By the way, for testing PDF generation

node .\scripts\generatePdf.js --lang fr

Hi ! ๐Ÿ‘‹
I'd be happy to give a hand on this.
As you seem to be taking care of the French version, would you like me to do the English one ?

Hello ๐Ÿ‘‹

I gladly accept your help @alexandrecoin! Yes do not hesitate to take care of the English one.

@alexandrecoin If you are motivated you can finish french (I was thinking doing it but I don't have much time in the coming days).

@fraxken Yes, will do. ๐Ÿ‘

Before doing so, I noticed there's actually an issue with the links that appear to be broken on both updated French and English versions.

Markdown links between parentheses are rendered as well.
alanshaw/markdown-pdf#212 (comment)

And it looks like paths require to include the chapters directory, otherwise they're a bit off.

Without the chapters directory
Capture dโ€™eฬcran 2022-11-21 aฬ€ 20 35 46

With the chapters directory
Capture dโ€™eฬcran 2022-11-21 aฬ€ 20 39 30

Still, the links remain non clickable ๐Ÿค”

Closing as I finished chapter re-order. Opened an issue for improvment of PDF generation: #18