frankosterfeld / qtkeychain

Platform-independent Qt API for storing passwords securely.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Handle KWallet timeouts

danimo opened this issue · comments

The wallet dbus interface can time out while waiting for kwallet (e.g. if password input is required, and qtkeychain does not recover from that. Instead, qtkeychain should handle timeouts and try again instead of failing.

Is there anything I can do to move this issue forward?

Provide a patch :)

@frankosterfeld Btw: is there any reason why kwallet and gnome keyring share the same impl file? i.e. any objections against tearing those two apart for great readability?

Separation would make sense indeed. I agree that it became overly complex. The reason to have them like this is that they're both need to be compiled under Linux, and the detection which one to use happens at runtime. But that should probably be refactored now.

This fix here is to ask klauncher to start kwallet by desktop file name and then wait until the call returns. By then, the wallet should be available and ready to query.

Dear all, this issue stays not fixed, and influences ownCloud client, as far as I understand from this bug discussion:
owncloud/client#3336 (comment)

Is there a way I could help you to eliminate this annoying usability and potential security problem?

This is indeed still an issue.

Still valid with Linux Mint 18, kwalletmanager 16.04.3.

Also still valid in OpenSUSE Leap 42.2, which includes the following packages:

  • kwallet-tools-5.26.0-2.1.x86_64
  • kwalletd5-5.26.0-2.1.x86_64
  • kwalletmanager5-16.08.2-3.1.x86_64
  • libqt5keychain1-0.7.0-1.3.x86_64
  • owncloud-client-2.2.4-9.1.x86_64
  • libowncloudsync0-2.2.4-9.1.x86_64