francesco-ficarola / gexf4j

A java library for the GEXF file format.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

NodeShapeImpl.setUri(String uri) method code missing

ParkHanbum opened this issue · comments

hi~ first, thank u for gexf4j. good job!

I find missing code block.
here

===== current ===========
@OverRide
public NodeShapeEntity setUri(String uri) {
checkArgument(uri != null, "URI cannot be set to null.");
return this;
}

==== maybe, this is right ===========
@OverRide
public NodeShapeEntity setUri(String uri) {
checkArgument(uri != null, "URI cannot be set to null.");
this.uri = uri;
return this;
}

it works!
handle on NodeShapeEntityWriter.

==============NodeShapeEntityWriter ======================
@OverRide
protected void writeAttributes() throws XMLStreamException {
writer.writeAttribute(
ATTRIB_VALUE,
entity.getNodeShape().toString().toLowerCase());

    if (entity.hasUri()) {
        writer.writeAttribute(
                ATTRIB_URI,
                entity.getUri());
    }
}

so, result
like this

#

Hi,

thank you for your contribution. You're right and I fixed the bug. I've also made other minor changes and I've released the version 0.4.4-BETA. The maven synchronization for the newer version will happen in a few hours, so please check it later: http://search.maven.org/#browse%7C322148902. Alternatively and in the meantime, you can update your local github version to try your test again.

Please let me know if the fix solves your problem in order to close this issue.

Thank you again.

Best regards,
Francesco