break into several smaller modules

Question

break into several smaller modules

fr1ll opened this issue 2 years ago · comments

Will Sanger commented 2 years ago

Mad Murphy · Answer 1 · Wed Apr 05 2023 00:38:43 GMT+0800 (China Standard Time)

Not sure where get_atlas_data() should go. Do we place in with web_config or images module?

Will Sanger · Answer 2 · Wed Apr 05 2023 01:16:18 GMT+0800 (China Standard Time)

Good question. 🤔

The images module handles jpgs, so I favor putting it there. Also, atlases are akin to thumbnails, and that's in images or should be.

Sound okay?

Mad Murphy · Answer 3 · Wed Apr 05 2023 01:49:03 GMT+0800 (China Standard Time)

I agree. I made the change in 97ab455.

Mad Murphy · Answer 4 · Wed Apr 05 2023 02:16:27 GMT+0800 (China Standard Time)

I want to change the function name of get_atlas_data. Function either gets atlas directory or creates atlas. Either way it always returns the atlas directory. It does not get or load any actual atlas data.

I am thinking create_atlas. What do you think?

Will Sanger · Answer 5 · Wed Apr 05 2023 09:31:53 GMT+0800 (China Standard Time)

Yes, agree. create_atlas is more clear.

Will Sanger · Answer 6 · Thu Aug 17 2023 02:32:51 GMT+0800 (China Standard Time)

Done throughout (too many commits to list) -- here's a major one: 76dd707